[webkit-reviews] review granted: [Bug 191228] Plain text drag in contenteditable is always DragOperationCopy, never DragOperationMove : [Attachment 354196] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Jonathan Hammer
<jonathan at e3software.com>'s request for review:
Bug 191228: Plain text drag in contenteditable is always DragOperationCopy,
never DragOperationMove
https://bugs.webkit.org/show_bug.cgi?id=191228

Attachment 354196: Patch

https://bugs.webkit.org/attachment.cgi?id=354196&action=review




--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 354196
  --> https://bugs.webkit.org/attachment.cgi?id=354196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354196&action=review

Nice! r=me, provided that EWS is happy.

> LayoutTests/fast/events/drag-and-drop-move-not-copy.html:18
> +   var range = document.createRange();

Do we need to create and set up this `range` here? It seems that setting base
and extent below should be sufficient to make a selection.