[webkit-reviews] review granted: [Bug 191378] Simplify macros in platform : [Attachment 354101] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 191378: Simplify macros in platform
https://bugs.webkit.org/show_bug.cgi?id=191378

Attachment 354101: Patch

https://bugs.webkit.org/attachment.cgi?id=354101&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 354101
  --> https://bugs.webkit.org/attachment.cgi?id=354101
Patch

This is iffy, but Don's changes seem reasonable. The problem is we do have a
lot of GTK/WPE-specific code used by both ports in files with the GLib (or
older Glib) suffix. So these macros *are* guarding WebKit's GLib
implementations of these functions... even if they have nothing to do with the
library GLib itself.