[webkit-reviews] review denied: [Bug 190609] [Curl] Enable Server-Timing Experimental Feature by default : [Attachment 354123] Path for USE(CURL)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 190609: [Curl] Enable Server-Timing Experimental Feature by default
https://bugs.webkit.org/show_bug.cgi?id=190609

Attachment 354123: Path for USE(CURL)

https://bugs.webkit.org/attachment.cgi?id=354123&action=review




--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 354123
  --> https://bugs.webkit.org/attachment.cgi?id=354123
Path for USE(CURL)

View in context: https://bugs.webkit.org/attachment.cgi?id=354123&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1308
> +  condition: USE(CURL)

This isn't the right way of enabling the feature only where CURL is used since
we still need to enable this feature by default in DRT/WTR.
You'd have to change defaultValue to a macro and then conditionally define that
macro.