[webkit-reviews] review granted: [Bug 191392] Click and touch event listeners on the body don't work : [Attachment 354130] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 13:26:43 PST 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 191392: Click and touch event listeners on the body don't work
https://bugs.webkit.org/show_bug.cgi?id=191392

Attachment 354130: Patch

https://bugs.webkit.org/attachment.cgi?id=354130&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 354130
  --> https://bugs.webkit.org/attachment.cgi?id=354130
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354130&action=review

I think it's worth adding a test for touch handlers.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=191392

Radar.

> LayoutTests/fast/events/click-handler-on-body-simple.html:13
> +		return;

Tabs?

> LayoutTests/fast/events/click-handler-on-body-simple.html:19
> +		result.innerHTML = "clicked";

Tab


More information about the webkit-reviews mailing list