[webkit-reviews] review requested: [Bug 191381] [iOS] Option + Delete should delete previous word : [Attachment 354104] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 7 10:22:32 PST 2018
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 191381: [iOS] Option + Delete should delete previous word
https://bugs.webkit.org/show_bug.cgi?id=191381
Attachment 354104: Patch
https://bugs.webkit.org/attachment.cgi?id=354104&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 354104
--> https://bugs.webkit.org/attachment.cgi?id=354104&action=review
Patch
It is not straightforward to write a test for this change because UIKit
determines the modifier keys pressed (e.g. Option) by querying the keyboard
directly. We could mock out the underlying keyboard though this seems fragile.
More information about the webkit-reviews
mailing list