[webkit-reviews] review granted: [Bug 191340] Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol generated objects : [Attachment 354049] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 191340: Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol
generated objects
https://bugs.webkit.org/show_bug.cgi?id=191340

Attachment 354049: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=354049&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354049
  --> https://bugs.webkit.org/attachment.cgi?id=354049
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354049&action=review

r=me

> Source/JavaScriptCore/inspector/scripts/codegen/generator.py:45
> +_ALWAYS_SPECIALCASED_ENUM_VALUE_SUBSTRINGS = set(['2D', 'API', 'CSS', 'DOM',
'HTML', 'JIT', 'XHR', 'XML', 'IOS', 'MacOS', 'JavaScript'])

While we're at it, shouldn't "IOS" be "iOS" and "MacOS" be "macOS"?