[webkit-reviews] review granted: [Bug 191342] Web Inspector: Debugger Popover does not work when paused in Worker : [Attachment 354045] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 191342: Web Inspector: Debugger Popover does not work when paused in Worker
https://bugs.webkit.org/show_bug.cgi?id=191342

Attachment 354045: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=354045&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354045
  --> https://bugs.webkit.org/attachment.cgi?id=354045
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354045&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1728
> +	   let target = WI.debuggerManager.activeCallFrame ?
WI.debuggerManager.activeCallFrame.target : this.target;

NIT: considering that `WI.debuggerManager.activeCallFrame` is used in a few
places in this function, making it into a separate variable seems reasonable
(e.g. `activeCallFrame` or even just `callFrame`)