[webkit-reviews] review granted: [Bug 190863] Customizable test group form should not reset manually edited commit value sometimes. : [Attachment 354038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 18:04:01 PST 2018


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 190863: Customizable test group form should not reset manually edited
commit value sometimes.
https://bugs.webkit.org/show_bug.cgi?id=190863

Attachment 354038: Patch

https://bugs.webkit.org/attachment.cgi?id=354038&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 354038
  --> https://bugs.webkit.org/attachment.cgi?id=354038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354038&action=review

>
Websites/perf.webkit.org/browser-tests/customizable-test-group-form-tests.js:78
> +	   let revisionEditors =
customizableTestGroupForm.content('custom-table').querySelectorAll('input:not([
type="radio"])');
> +	   expect(revisionEditors.length).to.be(2);
> +	   let revisionEditor = revisionEditors[0];

Use const?

>
Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js:2
59
> +			   alert(`Commit "${revisionEditor.value}" from
"${repository.name()}" does not exits.`);

I think a better error message would be `"${revisionEditor.value}" doesn't
exist in "${repository.name()}"`.
Saying that it's a commit is both redundant for regular repositories and
erroneous for OS versions.


More information about the webkit-reviews mailing list