[webkit-reviews] review denied: [Bug 191340] Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol generated objects : [Attachment 354033] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 191340: Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol
generated objects
https://bugs.webkit.org/show_bug.cgi?id=191340

Attachment 354033: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=354033&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 354033
  --> https://bugs.webkit.org/attachment.cgi?id=354033
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354033&action=review

Looks good, except for the issue mentioned.

>
Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendComman
ds.js:70
> +InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d",
BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", Webgpu:
"webgpu"});

The frontend uses CanvasAgent.ContextType.WebGPU. This change causes calls to
InspectorCanvasAgent::requestContent to fail with "unsupported canvas context
type".