[webkit-reviews] review granted: [Bug 191336] Add some basic pointer events tests : [Attachment 354021] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 191336: Add some basic pointer events tests
https://bugs.webkit.org/show_bug.cgi?id=191336

Attachment 354021: Patch

https://bugs.webkit.org/attachment.cgi?id=354021&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 354021
  --> https://bugs.webkit.org/attachment.cgi?id=354021
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354021&action=review

>
LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointeru
p.html:54
> +		   testRunner.runUIScript(getUIScript(50, 200, 60, 250, 0.3),
function(result) { });

I think these tests would be a bit cleaner if we used ui-helper.js and
basic-gestures.js, with async-await.

> LayoutTests/fast/events/pointer/ios/tap-gives-pointerdown-pointerup.html:47
> +		   testRunner.runUIScript(getUIScript(50, 200),
function(result) { });

Ditto.