[webkit-reviews] review granted: [Bug 190913] <picture> container doesn't update when prefers-color-scheme media query changes : [Attachment 353756] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 190913: <picture> container doesn't update when prefers-color-scheme media
query changes
https://bugs.webkit.org/show_bug.cgi?id=190913

Attachment 353756: Patch

https://bugs.webkit.org/attachment.cgi?id=353756&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353756
  --> https://bugs.webkit.org/attachment.cgi?id=353756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353756&action=review

> LayoutTests/css-dark-mode/prefers-color-scheme-picture-element.html:26
> +	   internals.settings.setUseDarkAppearance(true);

We default to using the light scheme no matter what the system says?

>
LayoutTests/platform/mac-highsierra/css-dark-mode/prefers-color-scheme-picture-
element-expected.txt:5
> +FAIL Picture image has the light source selected assert_regexp_match:
expected object "/\/light.png$/" but got
"file:///Volumes/Data/EWS/WebKit/LayoutTests/css-dark-mode/error.png"
> +PASS Dark color scheme enabled 
> +FAIL Picture image has the dark source selected assert_regexp_match:
expected object "/\/dark.png$/" but got
"file:///Volumes/Data/EWS/WebKit/LayoutTests/css-dark-mode/error.png"

Why don't we skip all of css-dark-mode on highsierra and sierra?