[webkit-reviews] review granted: [Bug 190774] Implement text-underline-offset and text-decoration-thickness : [Attachment 353951] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 190774: Implement text-underline-offset and text-decoration-thickness
https://bugs.webkit.org/show_bug.cgi?id=190774

Attachment 353951: Patch

https://bugs.webkit.org/attachment.cgi?id=353951&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353951
  --> https://bugs.webkit.org/attachment.cgi?id=353951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353951&action=review

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1703
> +	   new
PropertyWrapper<TextDecorationThickness>(CSSPropertyTextDecorationThickness,
&RenderStyle::textDecorationThickness,
&RenderStyle::setTextDecorationThickness),
> +	   new
PropertyWrapper<TextUnderlineOffset>(CSSPropertyTextUnderlineOffset,
&RenderStyle::textUnderlineOffset, &RenderStyle::setTextUnderlineOffset),

Animation! very nice.

>> Source/WebCore/rendering/TextDecorationPainter.cpp:288
>> +		int offset =
computeUnderlineOffset(m_lineStyle.textUnderlinePosition(),
m_lineStyle.textUnderlineOffset(), m_lineStyle.fontMetrics(), m_inlineTextBox,
m_lineStyle.computedFontSize() / 16);
> 
> It worth moving from a magic number to a constant to give some meaning here?

Agreed.