[webkit-reviews] review granted: [Bug 191308] CSS grid elements with justify-content: space-around have extra whitespace, sometimes a lot : [Attachment 353971] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 191308: CSS grid elements with justify-content: space-around have extra
whitespace, sometimes a lot
https://bugs.webkit.org/show_bug.cgi?id=191308

Attachment 353971: Patch

https://bugs.webkit.org/attachment.cgi?id=353971&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353971
  --> https://bugs.webkit.org/attachment.cgi?id=353971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353971&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:565
> +	   // FIXME (jfernandez) Content Alignment should account for this
heuristic

Nit. Punctuation.

> Source/WebCore/rendering/RenderGrid.cpp:1605
> +    auto& offset =
> +	   isRowAxis ? m_offsetBetweenColumns : m_offsetBetweenRows;

Nit: Should be one line.

> Source/WebCore/rendering/RenderGrid.cpp:1624
> +	   positionOffset = LayoutUnit();

I don't think this line is necessary.

> Source/WebCore/rendering/RenderGrid.cpp:1645
> +	       positionOffset = LayoutUnit();

Nor this one.

> Source/WebCore/rendering/RenderGrid.h:42
> +    bool isValid() { return positionOffset >= 0 && distributionOffset >= 0;
}

const