[webkit-reviews] review granted: [Bug 191261] Calling sender.replaceTrack() twice produces a new transceiver and its corresponding m= section : [Attachment 353952] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 07:19:10 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 191261: Calling sender.replaceTrack() twice produces a new transceiver and
its corresponding m= section
https://bugs.webkit.org/show_bug.cgi?id=191261

Attachment 353952: Patch

https://bugs.webkit.org/attachment.cgi?id=353952&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 353952
  --> https://bugs.webkit.org/attachment.cgi?id=353952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353952&action=review

> Source/WebCore/ChangeLog:11
> +	   Covered by updated test.

Nit: you should mention that you updated webrtc/video-addTransceiver.html to
test this.


More information about the webkit-reviews mailing list