[webkit-reviews] review requested: [Bug 190683] [GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder : [Attachment 353888] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 190683: [GStreamer][WebRTC] Do not try to handle framerate modulation in
the encoder
https://bugs.webkit.org/show_bug.cgi?id=190683

Attachment 353888: Patch

https://bugs.webkit.org/attachment.cgi?id=353888&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 353888
  --> https://bugs.webkit.org/attachment.cgi?id=353888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353888&action=review

> Source/WebCore/ChangeLog:12
> +	   No regressions detected and libwebrtc is happier this way, less
warning output and no more frame corruption in H264 streams found.

My only concern is we should have a test for this, I'll let Phil decide.