[webkit-reviews] review granted: [Bug 191271] Multiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and Release JSC testers. : [Attachment 353926] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 20:19:01 PST 2018


Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 191271: Multiple stress/regexp-compile-oom.js tests are failing on High
Sierra Debug and Release JSC testers.
https://bugs.webkit.org/show_bug.cgi?id=191271

Attachment 353926: Patch

https://bugs.webkit.org/attachment.cgi?id=353926&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 353926
  --> https://bugs.webkit.org/attachment.cgi?id=353926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353926&action=review

r=me

> JSTests/ChangeLog:8
> +	   Added more test cases and made all test cases runn with the same
deeply recursive stack

Typo: runn

> Source/JavaScriptCore/runtime/RegExpPrototype.cpp:502
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

Maybe just release the scope before the above call since this is the last
thing? That way we avoid the branch


More information about the webkit-reviews mailing list