[webkit-reviews] review granted: [Bug 191239] Cache glyph paths and share underline skipping code between all the ports : [Attachment 353881] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 14:44:35 PST 2018


Alex Christensen <achristensen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 191239: Cache glyph paths and share underline skipping code between all the
ports
https://bugs.webkit.org/show_bug.cgi?id=191239

Attachment 353881: Patch

https://bugs.webkit.org/attachment.cgi?id=353881&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 353881
  --> https://bugs.webkit.org/attachment.cgi?id=353881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1241
> +enum class GlyphUnderlineType {

: uint8_t

> Source/WebCore/platform/graphics/FontCascade.cpp:1669
> +    GlyphIterationState(FloatPoint startingPoint, FloatPoint currentPoint,
float y1, float y2, float minX, float maxX)

It seems like this constructor could be omitted by using an initializer list
where this constructor is called.


More information about the webkit-reviews mailing list