[webkit-reviews] review granted: [Bug 190764] Spelling dots are drawn in the wrong place : [Attachment 353807] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 190764: Spelling dots are drawn in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=190764

Attachment 353807: Patch

https://bugs.webkit.org/attachment.cgi?id=353807&action=review




--- Comment #29 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353807
  --> https://bugs.webkit.org/attachment.cgi?id=353807
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353807&action=review

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:224
> +
> +	   // Toggle on before the test, and toggle off after the test.
> +	   if (options.shouldShowSpellCheckingDots)
> +	       [platformView toggleContinuousSpellChecking:nil];

Why not just add it to the list of incompatible options that require a new
WebView to be created?