[webkit-reviews] review granted: [Bug 158342] Overlay with -webkit-overflow-scrolling:touch doesn't become scrollable after added text makes it taller : [Attachment 353880] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 158342: Overlay with -webkit-overflow-scrolling:touch doesn't become
scrollable after added text makes it taller
https://bugs.webkit.org/show_bug.cgi?id=158342

Attachment 353880: Patch

https://bugs.webkit.org/attachment.cgi?id=353880&action=review




--- Comment #21 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 353880
  --> https://bugs.webkit.org/attachment.cgi?id=353880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353880&action=review

> LayoutTests/fast/scrolling/ios/update-scroll-coordinated-status.html:5
> +    <title>Update scroll coordinated status</title>
> +    <meta charset="utf-8"/>

You can remove these.

> LayoutTests/fast/scrolling/ios/update-scroll-coordinated-status.html:14
> +	 position: fixed;
> +	    width: 200px;
> +	    height: 200px;
> +	    overflow: auto;
> +	    -webkit-overflow-scrolling: touch;
> +	    border: 5px solid orange;
> +	    margin: 5px;

Bad indentation.

> LayoutTests/fast/scrolling/ios/update-scroll-coordinated-status.html:23
> +	 .scrollable-content {
> +	   width: 100px;
> +	   height: 100px;
> +	   background: linear-gradient(135deg, yellow, cyan);
> +	 }
> +	 .overflowing {
> +	   height: 400px;
> +	 }

CSS should have 4-space indentation