[webkit-reviews] review granted: [Bug 191242] Parsing support for text-underline-offset and text-decoration-thickness : [Attachment 353826] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 191242: Parsing support for text-underline-offset and
text-decoration-thickness
https://bugs.webkit.org/show_bug.cgi?id=191242

Attachment 353826: Patch

https://bugs.webkit.org/attachment.cgi?id=353826&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 353826
  --> https://bugs.webkit.org/attachment.cgi?id=353826
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review

> Source/WebCore/rendering/style/StyleRareInheritedData.h:85
> +    TextUnderlineOffset textUnderlineOffset;

Why not put into the bitfield?

> Source/WebCore/rendering/style/TextDecorationThickness.h:109
> +    Type m_type;
> +    float m_length;

3 bytes of padding here, sadly, and the float is wasted for the "from font"
case.