[webkit-reviews] review canceled: [Bug 190035] [GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects : [Attachment 353868] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 5 10:40:45 PST 2018
Philippe Normand <pnormand at igalia.com> has canceled Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 190035: [GStreamer] Fix EncodedImage timestamps to match what libWebRTC
expects
https://bugs.webkit.org/show_bug.cgi?id=190035
Attachment 353868: Patch
https://bugs.webkit.org/attachment.cgi?id=353868&action=review
--- Comment #5 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 353868
--> https://bugs.webkit.org/attachment.cgi?id=353868
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=353868&action=review
>
Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
70
> + , m_adapter(adoptGRef(gst_adapter_new()))
Hum. I think this needs a GRefPtrGStreamer template specialization to avoid
leaks.
More information about the webkit-reviews
mailing list