[webkit-reviews] review granted: [Bug 190839] CSSCalcOperation ctor wastes 6KB of Vector capacity on cnn.com : [Attachment 352991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 05:23:07 PST 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 190839: CSSCalcOperation ctor wastes 6KB of Vector capacity on cnn.com
https://bugs.webkit.org/show_bug.cgi?id=190839

Attachment 352991: Patch

https://bugs.webkit.org/attachment.cgi?id=352991&action=review




--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 352991
  --> https://bugs.webkit.org/attachment.cgi?id=352991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352991&action=review

> Source/WebCore/ChangeLog:3
> +	   CSSCalcOperation ctor wastes 6KB of Vector capacity on cnn.com

Can we please write "constructor" everywhere in this patch and for the bug
title?

> Source/WebCore/ChangeLog:8
> +	   The CSSCalcOperation ctor that takes a left and rightSide parameter

leftSide and rightSide parameters


More information about the webkit-reviews mailing list