[webkit-reviews] review granted: [Bug 191251] Remove some virtual methods in CachedRawResource : [Attachment 353837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 04:50:59 PST 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 191251: Remove some virtual methods in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=191251

Attachment 353837: Patch

https://bugs.webkit.org/attachment.cgi?id=353837&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 353837
  --> https://bugs.webkit.org/attachment.cgi?id=353837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review

> Source/WebCore/loader/cache/CachedRawResource.h:-40
> -    // This can be fixed by splitting CORS preflighting out of
DocumentThreacableLoader.

What's this FIXME referring to? Is it just an obsolete comment? Can you mention
in the ChangeLog why we remove this?


More information about the webkit-reviews mailing list