[webkit-reviews] review granted: [Bug 191238] Expose a constructor for PointerEvent from PlatformTouchEvent : [Attachment 353813] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 191238: Expose a constructor for PointerEvent from PlatformTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=191238

Attachment 353813: Patch

https://bugs.webkit.org/attachment.cgi?id=353813&action=review




--- Comment #5 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 353813
  --> https://bugs.webkit.org/attachment.cgi?id=353813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353813&action=review

> Source/WebCore/dom/ios/PointerEventIOS.cpp:59
> +    : MouseEvent(type, CanBubble::Yes, IsCancelable::No, IsComposed::Yes,
event.timestamp().approximateMonotonicTime(), WTFMove(view), 0,
event.touchLocationAtIndex(index), event.touchLocationAtIndex(index), { },
event.modifiers(), 0, 0, nullptr, 0, 0, nullptr, IsSimulated::No,
IsTrusted::Yes)

Only "pointercancel" is non-cancelable, the other types returned by eventType()
are cancelable.

> Source/WebCore/dom/ios/PointerEventIOS.cpp:62
> +    , m_height(2 * event.radiusYAtIndex(index))

Where is this 2 coming from?