[webkit-reviews] review granted: [Bug 191184] REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled : [Attachment 353687] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 191184: REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was
disabled
https://bugs.webkit.org/show_bug.cgi?id=191184

Attachment 353687: Patch

https://bugs.webkit.org/attachment.cgi?id=353687&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 353687
  --> https://bugs.webkit.org/attachment.cgi?id=353687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353687&action=review

r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   REGRESSION(r237547): Exception handlers should be aware of wide
opcodes when JIT is disabled

Remove this entry from the changelog since it’s for a different bug.

> Source/JavaScriptCore/jit/JITExceptions.cpp:76
> +	   catchRoutine = catchPCForInterpreter->isWide()

I think this already landed?