[webkit-reviews] review granted: [Bug 191229] [LFC][BFC] Add support for block level non-replaced inflow height percentage : [Attachment 353785] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191229: [LFC][BFC] Add support for block level non-replaced inflow height
percentage
https://bugs.webkit.org/show_bug.cgi?id=191229

Attachment 353785: Patch

https://bugs.webkit.org/attachment.cgi?id=353785&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353785
  --> https://bugs.webkit.org/attachment.cgi?id=353785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353785&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:110
> +	   auto height = usedHeight ? usedHeight.value() :
computedHeightValue(layoutState, layoutBox,
FormattingContext::Geometry::HeightType::Normal);

HeightType::Normal might be enough?