[webkit-reviews] review granted: [Bug 191192] Add support for sender/receiver getCapabilities : [Attachment 353789] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 191192: Add support for sender/receiver getCapabilities
https://bugs.webkit.org/show_bug.cgi?id=191192

Attachment 353789: Patch

https://bugs.webkit.org/attachment.cgi?id=353789&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 353789
  --> https://bugs.webkit.org/attachment.cgi?id=353789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353789&action=review

> Source/WebCore/ChangeLog:9
> +	   Add corresponding IDL and plumbery down to libwebrtc peer connection
factory.

Nit: s/plumbery/plumbing/

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:64
> +    return { };

Nit: ASSERT_NOT_REACHED()?

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:69
> +    return { };

Ditto.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:302
> +    return static_cast<uint32_t>(*numChannels);

Nit: safeCast<uint32_t>?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:310
> +    for (auto& codec : rtpCapabilities.codecs)

Ditto.