[webkit-reviews] review granted: [Bug 191224] [LFC][BFC] Resolve percentage height values. : [Attachment 353761] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191224: [LFC][BFC] Resolve percentage height values.
https://bugs.webkit.org/show_bug.cgi?id=191224

Attachment 353761: Patch

https://bugs.webkit.org/attachment.cgi?id=353761&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353761
  --> https://bugs.webkit.org/attachment.cgi?id=353761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353761&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:60
> +enum class HeightType { Min, Max };

How about adding type Logical and using this without optional?