[webkit-reviews] review granted: [Bug 190979] Add new global object and preliminary Worklets support for CSS painting api : [Attachment 353643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 14:40:24 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 190979: Add new global object and preliminary Worklets support for CSS
painting api
https://bugs.webkit.org/show_bug.cgi?id=190979

Attachment 353643: Patch

https://bugs.webkit.org/attachment.cgi?id=353643&action=review




--- Comment #33 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 353643
  --> https://bugs.webkit.org/attachment.cgi?id=353643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353643&action=review

r=me

>> Source/WebCore/worklets/WorkletScriptController.cpp:157
>> +void WorkletScriptController::evaluate(const ScriptSourceCode& sourceCode,
NakedPtr<JSC::Exception>& returnedException, String* returnedExceptionMessage)
> 
> Can you confirm this is correct? Worklets have a unique opaque origin, so
normally this would always sanitize exception messages. At the same time, it is
important that exceptions show up in the inspector. As far as I know, there is
nowhere where a worklet can import a cross-origin script (do ES6 modules allow
cross-origin imports?), so this is safe.

You are not exposing this exception message to JS, are you? Logging it in
WebInspector does not count as passing it to JS.


More information about the webkit-reviews mailing list