[webkit-reviews] review requested: [Bug 191201] Do not re-declare soft-linked functions in SOFT_LINK* macros : [Attachment 353721] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 191201: Do not re-declare soft-linked functions in SOFT_LINK* macros
https://bugs.webkit.org/show_bug.cgi?id=191201

Attachment 353721: Patch

https://bugs.webkit.org/attachment.cgi?id=353721&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 353721
  --> https://bugs.webkit.org/attachment.cgi?id=353721
Patch

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 353721 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353721&action=review
> 
> > Source/WTF/ChangeLog:8
> > +	     Re-declaring soft-linked functions can cause build errors when
upstream frameworks change, for example, their export attributes
> 
> This is a good thing, we don’t want to diverge from what the framework
> declares. 
> 
> It’s similar to how we redeclare as much as possible in SOI headers.

I get the goal. But we explicitly redeclare them as __always_inline__ and
visibility('hidden') attributes to our own redeclaration, so we are explicitly
redeclaring them to be different than the framework.  So if this is our goal,
we need to stop doing that. Until then, your premise is invalid.