[webkit-reviews] review denied: [Bug 191201] Do not re-declare soft-linked functions in SOFT_LINK* macros : [Attachment 353721] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 12:31:40 PDT 2018


Alexey Proskuryakov <ap at webkit.org> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 191201: Do not re-declare soft-linked functions in SOFT_LINK* macros
https://bugs.webkit.org/show_bug.cgi?id=191201

Attachment 353721: Patch

https://bugs.webkit.org/attachment.cgi?id=353721&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 353721
  --> https://bugs.webkit.org/attachment.cgi?id=353721
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353721&action=review

> Source/WTF/ChangeLog:8
> +	   Re-declaring soft-linked functions can cause build errors when
upstream frameworks change, for example, their export attributes

This is a good thing, we don’t want to diverge from what the framework
declares. 

It’s similar to how we redeclare as much as possible in SOI headers.


More information about the webkit-reviews mailing list