[webkit-reviews] review requested: [Bug 191188] Add support for RTCMuxPolicy : [Attachment 353688] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 07:01:18 PDT 2018


youenn fablet <youennf at gmail.com> has asked  for review:
Bug 191188: Add support for RTCMuxPolicy
https://bugs.webkit.org/show_bug.cgi?id=191188

Attachment 353688: Patch

https://bugs.webkit.org/attachment.cgi?id=353688&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 353688
  --> https://bugs.webkit.org/attachment.cgi?id=353688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353688&action=review

> Source/WebCore/platform/mediastream/MediaEndpointConfiguration.cpp:39
>
+MediaEndpointConfiguration::MediaEndpointConfiguration(Vector<IceServerInfo>&&
iceServers, RTCIceTransportPolicy iceTransportPolicy, RTCBundlePolicy
bundlePolicy, RTCPMuxPolicy rtcpMuxPolicy, unsigned short iceCandidatePoolSize,
Vector<CertificatePEM>&& certificates)

We might be able to remove this constructor.
I'll try that in a separate patch.

> Source/WebCore/platform/mediastream/RTCPMuxPolicy.h:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

Will fix it to 2018.


More information about the webkit-reviews mailing list