[webkit-reviews] review denied: [Bug 191146] [Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class" : [Attachment 353588] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 191146: [Win][Clang][JSC] JIT::is64BitType reports "warning: explicit
specialization cannot have a storage class"
https://bugs.webkit.org/show_bug.cgi?id=191146

Attachment 353588: Patch

https://bugs.webkit.org/attachment.cgi?id=353588&action=review




--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 353588
  --> https://bugs.webkit.org/attachment.cgi?id=353588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353588&action=review

>> Source/JavaScriptCore/jit/JIT.h:791
>> +	    };
> 
> Could we drop `static` and move this to an anonymous namespace instead?
> It probably shouldn't have been a member to begin with... 😓

I tested both patches with both compilers, and confirmed both
works fine. I prefer the inner template class version to template
class version because anonymous namespace is useless in Unified
Source Builds.

C++14 has template variable. I will refine the patch.