[webkit-reviews] review granted: [Bug 191176] Web Inspector: View: introduce an afterLayout : [Attachment 353662] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 17:36:08 PDT 2018
Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 191176: Web Inspector: View: introduce an afterLayout
https://bugs.webkit.org/show_bug.cgi?id=191176
Attachment 353662: Patch
https://bugs.webkit.org/attachment.cgi?id=353662&action=review
--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 353662
--> https://bugs.webkit.org/attachment.cgi?id=353662
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=353662&action=review
r=me
> LayoutTests/ChangeLog:10
> + (TestPage.registerInitializer.WI.TestView.prototype.afterLayout):
Added.
r=me. Overall this looks good! I'm not sure about the method name though; what
about didLayout, or didLayoutSubtree?
More information about the webkit-reviews
mailing list