[webkit-reviews] review granted: [Bug 191119] In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not : [Attachment 353654] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 191119: In WebCore::ResourceLoadObserver, use
document.sessionID().isEphemeral() when possible and check for page existence
when not
https://bugs.webkit.org/show_bug.cgi?id=191119

Attachment 353654: Patch

https://bugs.webkit.org/attachment.cgi?id=353654&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 353654
  --> https://bugs.webkit.org/attachment.cgi?id=353654
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353654&action=review

> Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm:74
> +    RetainPtr<ClosingWebViewThenSendingItAKeyDownEventLoadDelegate>
loadDelegate = adoptNS([[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate
alloc] init]);

auto