[webkit-reviews] review requested: [Bug 191173] Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67) : [Attachment 353651] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 15:33:45 PDT 2018
Nikita Vasilyev <nvasilyev at apple.com> has asked for review:
Bug 191173: Uncaught Exception: TypeError: undefined is not an object
(evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173
Attachment 353651: Patch
https://bugs.webkit.org/attachment.cgi?id=353651&action=review
--- Comment #1 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 353651
--> https://bugs.webkit.org/attachment.cgi?id=353651&action=review
Patch
This was likely a recent regression. Regardless of that, it was odd to have
`WI.modifierKeys` initialized somewhere in the middle of WI.contentLoaded — it
should come before that.
More information about the webkit-reviews
mailing list