[webkit-reviews] review granted: [Bug 191091] Add Basic Django web app for OpenSource EWS : [Attachment 353508] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 191091: Add Basic Django web app for OpenSource EWS
https://bugs.webkit.org/show_bug.cgi?id=191091

Attachment 353508: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=353508&action=review




--- Comment #4 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 353508
  --> https://bugs.webkit.org/attachment.cgi?id=353508
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353508&action=review

> Tools/BuildSlaveSupport/EWS_app/EWS_app/settings.py:44
> +SECRET_KEY = 'b)6 at _-&5hz(s2-qwt()em3 at 1yt91=@g=!guu_nz&)u5fb0k+he'

please remove and rotate pw.

> Tools/ChangeLog:9
> +	   * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added,
auto-generated by Django.

I'm not familiar with django development, but is it normal to have a subfolder
with the same name as the parent? (EWS_app/EWS_app)?