[webkit-reviews] review granted: [Bug 191156] [Apache] Self-signed SSL certificate RSA key is considered too weak : [Attachment 353632] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 191156: [Apache] Self-signed SSL certificate RSA key is considered too weak
https://bugs.webkit.org/show_bug.cgi?id=191156

Attachment 353632: Patch

https://bugs.webkit.org/attachment.cgi?id=353632&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 353632
  --> https://bugs.webkit.org/attachment.cgi?id=353632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353632&action=review

Wait for EWS please.

> Tools/Scripts/webkitpy/common/system/pemfile.py:94
> -RSA_PRIVATE_KEY = "RSA PRIVATE KEY"
> +RSA_PRIVATE_KEY = "PRIVATE KEY"

Hm, I wonder why this is needed?

You should also rename the variable RSA_PRIVATE_KEY to PRIVATE_KEY.