[webkit-reviews] review granted: [Bug 191078] [iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired. : [Attachment 353624] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191078: [iOS] Issue initial paint soon after the visuallyNonEmpty milestone
is fired.
https://bugs.webkit.org/show_bug.cgi?id=191078

Attachment 353624: Patch

https://bugs.webkit.org/attachment.cgi?id=353624&action=review




--- Comment #11 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353624
  --> https://bugs.webkit.org/attachment.cgi?id=353624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353624&action=review

r=me. Interesting to see how the perf bots like this.

> Source/WebCore/dom/Document.cpp:1810
> +    const auto styleRecalcDelay = 50_ms;

I suppose there is some deep science here?

> Source/WebCore/dom/Document.cpp:1811
> +    m_styleRecalcTimer.startOneShot(throttleStyleRecalc ? styleRecalcDelay :
0_s);

Maybe this change could be done separately?

> Source/WebCore/rendering/RenderText.cpp:203
> +    // FIXME: Find out how to increment the visually non empty character
count when the font becomes available.

Maybe this stuff needs to move to RenderText::styleDidChange