[webkit-reviews] review granted: [Bug 190598] Add a storage limit for IndexedDB : [Attachment 353419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 09:09:34 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 190598: Add a storage limit for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=190598

Attachment 353419: Patch

https://bugs.webkit.org/attachment.cgi?id=353419&action=review




--- Comment #59 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 353419
  --> https://bugs.webkit.org/attachment.cgi?id=353419
Patch

r=me but the inconsistency between WK1 and WK2 bother me and I think we should
align both before landing:
- WK2 has m_idbPerOriginQuota be IDBServer::defaultPerOriginQuota by default
and sets it on the IDBServer no matter what
- WK1 has m_idbPerOriginQuota be 0 by default and only sets it on the IDBServer
if the value is not 0

Please choose align both (I let you choose which one you prefer).


More information about the webkit-reviews mailing list