[webkit-reviews] review granted: [Bug 190778] MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called : [Attachment 353572] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 190778: MediaRecorder should fire dataavailable event when all tracks are
ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778

Attachment 353572: Patch

https://bugs.webkit.org/attachment.cgi?id=353572&action=review




--- Comment #61 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 353572
  --> https://bugs.webkit.org/attachment.cgi?id=353572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353572&action=review

> LayoutTests/ChangeLog:9
> +	   Remove share FileReader object between three asynchronous tests
which might cause flaky failure.

This kind of issue often happens with asynchronous tests.
I recommend not using async_test directly. Instead
- Use promise_test in multi test pages (promise_test is just a way to trigger
async_test that are executed one after the other).
- Use single page test which wraps the asserts in an async_test that
testharness.js creates for you.