[webkit-reviews] review denied: [Bug 185976] Improve the performance of determining character boundaries in ComplexTextController : [Attachment 341718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 19:54:14 PDT 2018


mitz at webkit.org has denied Myles C. Maxfield <mmaxfield at apple.com>'s request
for review:
Bug 185976: Improve the performance of determining character boundaries in
ComplexTextController
https://bugs.webkit.org/show_bug.cgi?id=185976

Attachment 341718: Patch

https://bugs.webkit.org/attachment.cgi?id=341718&action=review




--- Comment #41 from mitz at webkit.org ---
Comment on attachment 341718
  --> https://bugs.webkit.org/attachment.cgi?id=341718
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341718&action=review

> LayoutTests/ChangeLog:14
> +	   * platform/mac/fast/text/format-control-expected.png:
> +	   * platform/mac/fast/text/format-control-expected.txt: Rebaseline.

This test is regressing! For example, the presence of a zero-width non-joiner
is no longer preventing the fi ligature from forming on the second line.


More information about the webkit-reviews mailing list