[webkit-reviews] review granted: [Bug 186134] [Win][MiniBrowser] Remove gMiniBrowser global variable : [Attachment 341710] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 186134: [Win][MiniBrowser] Remove gMiniBrowser global variable
https://bugs.webkit.org/show_bug.cgi?id=186134

Attachment 341710: Patch

https://bugs.webkit.org/attachment.cgi?id=341710&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 341710
  --> https://bugs.webkit.org/attachment.cgi?id=341710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341710&action=review

r=me

> Tools/MiniBrowser/win/MainWindow.cpp:136
> +    MainWindow* thiz = reinterpret_cast<MainWindow*>(GetWindowLongPtr(hWnd,
GWLP_USERDATA));

Is it possible for thiz to be null?

Likewise, is it possible for thiz->browserWindow() to return a nullptr?

If not, why isn't browserWindow() returning a reference?

> Tools/MiniBrowser/win/MainWindow.cpp:448
> +    *(reinterpret_cast<LPWORD>(strPtr)) = INTERNET_MAX_URL_LENGTH;

Could this be done with some kind of modern VisualStudio BSTR type? This seems
so gross and likely to be confusing to someone unfamiliar with this.

I realize this is just existing code you moved, but it's still not very nice.