[webkit-reviews] review granted: [Bug 186160] Cache toString results for CoW arrays : [Attachment 341701] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 186160: Cache toString results for CoW arrays
https://bugs.webkit.org/show_bug.cgi?id=186160

Attachment 341701: patch

https://bugs.webkit.org/attachment.cgi?id=341701&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 341701
  --> https://bugs.webkit.org/attachment.cgi?id=341701
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341701&action=review

r=me with comments.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:388
> +static inline bool canUseFastJoin(const JSObject* thisObject)

Why both static and inline? that's the same as just inline...

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:416
> +template<typename T> static inline bool containsHole(T* data, unsigned
length)

Newline between the template and the rest of the declaration.