[webkit-reviews] review denied: [Bug 184485] Add JIT entitlements to WebContent process and plugin process on macOS : [Attachment 341668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 10:06:14 PDT 2018


mitz at webkit.org has denied Brent Fulgham <bfulgham at webkit.org>'s request for
review:
Bug 184485: Add JIT entitlements to WebContent process and plugin process on
macOS
https://bugs.webkit.org/show_bug.cgi?id=184485

Attachment 341668: Patch

https://bugs.webkit.org/attachment.cgi?id=341668&action=review




--- Comment #7 from mitz at webkit.org ---
Comment on attachment 341668
  --> https://bugs.webkit.org/attachment.cgi?id=341668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341668&action=review

> Source/WebKit/ChangeLog:12
> +	   1. Adds a new process-plugin-entitlements.sh script, which
conditionally adds the restricted JIT entitlement

My understanding and knowledge is that the JIT entitlement is *not* restricted.
So granting it shouldn’t be conditional on whether we’re building with
restricted entitlements.


More information about the webkit-reviews mailing list