[webkit-reviews] review granted: [Bug 186117] [LFC] Layout code needs to know the type of the Element associated with a Layout::Box : [Attachment 341620] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 186117: [LFC] Layout code needs to know the type of the Element associated
with a Layout::Box
https://bugs.webkit.org/show_bug.cgi?id=186117

Attachment 341620: Patch

https://bugs.webkit.org/attachment.cgi?id=341620&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 341620
  --> https://bugs.webkit.org/attachment.cgi?id=341620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341620&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:120
> +    struct ElementAttributes {
> +	   ElementAttributes(ElementType elementType)
> +	       : elementType(elementType)
> +	       {
> +	       }
> +
> +	   ElementType elementType;
> +    };

Indentation for
{
}
is wrong.

Is the constructor needed? Maybe this could just use bracket initialization?