[webkit-reviews] review granted: [Bug 185526] [macOS] WebProcess needs TCC entitlements for media capture (Take 2) : [Attachment 341591] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 30 15:08:36 PDT 2018
Alexey Proskuryakov <ap at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 185526: [macOS] WebProcess needs TCC entitlements for media capture (Take
2)
https://bugs.webkit.org/show_bug.cgi?id=185526
Attachment 341591: Patch
https://bugs.webkit.org/attachment.cgi?id=341591&action=review
--- Comment #30 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 341591
--> https://bugs.webkit.org/attachment.cgi?id=341591
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=341591&action=review
> Source/WebKit/Configurations/DebugRelease.xcconfig:48
> +CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
Does this silently evaluate to empty string when WK_USE_RESTRICTED_ENTITLEMENTS
is YES, but WK_ENGINEERING_CODE_SIGN_IDENTITY is undefined?
> Source/WebKit/Scripts/process-webcontent-entitlements.sh:26
> + echo "Processing for Open Source SDK"
This will be confusing in the build output. Processing what?
> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:131
> -#if ENABLE(SANDBOX_EXTENSIONS)
> +#if ENABLE(SANDBOX_EXTENSIONS) && USE(APPLE_INTERNAL_SDK)
Do we actually want this change on all macOS versions?
> Source/WebKit/WebKit.xcodeproj/project.pbxproj:10373
> + 7A35F25020BDB7CC003958EC /* Remove stale entitlement file */ =
{
Why do we have two of these? Here...
> Source/WebKit/WebKit.xcodeproj/project.pbxproj:10391
> + 7A35F25120BDB80C003958EC /* Remove stale entitlement file */ =
{
...and here.
More information about the webkit-reviews
mailing list