[webkit-reviews] review granted: [Bug 186105] Fix the ENABLE(DATALIST_ELEMENT) build : [Attachment 341589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 12:18:17 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 186105: Fix the ENABLE(DATALIST_ELEMENT) build
https://bugs.webkit.org/show_bug.cgi?id=186105

Attachment 341589: Patch

https://bugs.webkit.org/attachment.cgi?id=341589&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 341589
  --> https://bugs.webkit.org/attachment.cgi?id=341589
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341589&action=review

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:52
> +#include <WebCore/HTMLDataListElement.h>

Super minor nit — we generally prefer to put conditional header includes like
this after the last unconditional header include (in this case, after `#include
<wtf/UUID.h>`).


More information about the webkit-reviews mailing list