[webkit-reviews] review granted: [Bug 186063] Media elements outside fullscreen should not be considered main content. : [Attachment 341528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 10:11:43 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 186063: Media elements outside fullscreen should not be considered main
content.
https://bugs.webkit.org/show_bug.cgi?id=186063

Attachment 341528: Patch

https://bugs.webkit.org/attachment.cgi?id=341528&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 341528
  --> https://bugs.webkit.org/attachment.cgi?id=341528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341528&action=review

> Source/WebCore/testing/Internals.h:45
> +#if ENABLE(VIDEO)
> +#include "MediaElementSession.h"
> +#endif

Nit: you can forward declare the enum instead of including the header here


More information about the webkit-reviews mailing list