[webkit-reviews] review granted: [Bug 185967] Rope string sweeping should avoid touching unresolved ropes : [Attachment 341413] the patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 185967: Rope string sweeping should avoid touching unresolved ropes
https://bugs.webkit.org/show_bug.cgi?id=185967

Attachment 341413: the patch

https://bugs.webkit.org/attachment.cgi?id=341413&action=review




--- Comment #9 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 341413
  --> https://bugs.webkit.org/attachment.cgi?id=341413
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341413&action=review

r=me

> Source/JavaScriptCore/heap/MarkedBlock.cpp:460
> +void MarkedBlock::Handle::sweep(FreeList* freeList)

Replacing the position of `MarkedBlock::Handle::sweep` and
`MarkedBlock::Handle::finishSweepWithNoDestructors` would make diff clean.